[channel loss]support packing & padding free #4666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 23, 2025 14:11
kevssim
changed the title
Jintao-Huang
approved these changes
Jun 23, 2025
swift/plugin/loss.py
Outdated
| mask = flat_labels != -100 | ||
|
|
||
| if position_ids is not None and logits.size(0) == 1: | ||
| pos = position_ids[..., :-1].view(-1).tolist() |
There was a problem hiding this comment.
这个可以向量化嘛
参考这里：
ms-swift/swift/trainers/mixin.py
Line 542 in 3f4b4f1
方便加个 trainer.template.padding_free的检测不
There was a problem hiding this comment.
向量化：已修改。
检测：因为packing和padding_free都需要走这部分处理逻辑，所以改为用trainer.template._packing判断，ok不
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR type
PR information
Write the detail information belongs to this PR.
Experiment results
Paste your experiment result here(if needed).