Stub out class #33
Stub out class #33
Conversation
https://raw.githubusercontent.com/gtk-rs/gir-files/master/Gtk-3.0.gir <class name="EntryIconAccessible"> element is a good example CType isn't set.
decriptor
force-pushed
the
stub-out-class
branch
from
bf3bce5 to
2073ac1
Compare
|
|
||
| public static (string both, string names) BuildParameters(List<Parameter> parameters) | ||
| { | ||
| var typeAndName = new Dictionary<string, string>(); |
There was a problem hiding this comment.
This does not preserve order!
There was a problem hiding this comment.
Would an OrderedDictionary fix this?
There was a problem hiding this comment.
Sure but we don't really need a dictionary structure here, a list is sufficient since we don't care for fast lookups
There was a problem hiding this comment.
@Therzok already fixed this in master
| sb.AppendFormat("{0} {1}, ", pair.Key, pair.Value); | ||
| } | ||
| string parameterString = sb.ToString(); | ||
| parameterString = parameterString.Substring(0, parameterString.Length - 2); |
There was a problem hiding this comment.
This will fail with no elements. I'm also not sure why to cut off everything but the last two characters. Did you wanted to cut off the trailing ", "?
There was a problem hiding this comment.
I do want to cut the trailing ", " because that isn't valid c#.
ie, if I have 1 parameter string value it'll set parameterString to string value, . This is just trimming off that closing , .
There was a problem hiding this comment.
Ah, I misread that statement but anyway it fails when there are no parameters.
There was a problem hiding this comment.
true, but this has also been rewritten in master :)
There was a problem hiding this comment.
Yeah, sorry for not making a PR. Thought I was on a branch and pushed to master :(
I'm somewhat guess at what we want here. Hopefully there is some useful stuff in here.