Interface work #37
Interface work #37
Conversation
src/Gir/GenerationOptions.cs
Outdated
| @@ -20,8 +20,8 @@ public sealed class GenerationOptions | |||
| #endregion | |||
|
|
|||
| #region Generation toggles | |||
| readonly bool compat; | |||
| public bool GenerateDocumentation { get { return !compat; } } | |||
| public bool Compat { get; } | |||
There was a problem hiding this comment.
Can we make this compat bool back into a field and expose different generation toggles? It makes more sense to say:
if (opts.GenerateInterfacesWithIPrefix) rather than if (opts.Compat)
src/Gir.Tests/InterfaceTests.cs
Outdated
| @@ -157,7 +157,7 @@ public interface IComponent | |||
| /// a handler id which can be used in atk_component_remove_focus_handler() | |||
| /// or zero if the handler was already added. | |||
| ///</returns> | |||
| uint AddFocusHandler PARAMS | |||
There was a problem hiding this comment.
So, if a parent of a method is an interface, we need to generate the function definition without the body. public modifier is extraneous. We also should not generate pinvoke imports.
| @@ -71,7 +71,9 @@ public static void GenerateCallableDefinition(this ICallable callable, IndentWri | |||
| var returnType = callable.GetReturnCSharpType(writer); | |||
|
|
|||
| // generate ReturnValue then Parameters | |||
| writer.Write(string.Format("{0} {1} {2}", returnType, callable.Name.ToCSharp (), "PARAMS")); | |||
| // FIXME, probably don't need the instance parameters? | |||
There was a problem hiding this comment.
We can get the type from the symbol table, since Array exposes a CType. We can probably make Array an ISymbol and implement it.
src/Gir.Tests/ClassTests.cs
Outdated
| @@ -34,15 +34,15 @@ public void TestClassIsGenerated() | |||
| ///</summary> | |||
| public class BufferedOutputStream : Seekable | |||
| { | |||
| static extern OutputStream g_buffered_output_stream_new (OutputStream base_stream) | |||
| static extern OutputStream g_buffered_output_stream_new (OutputStream base_stream); | |||
src/Gir.Tests/InterfaceTests.cs
Outdated
| @@ -153,6 +153,8 @@ public interface IComponent | |||
| /// when this object receives focus events (in or out). If the handler is | |||
| /// already added it is not added again | |||
| ///</summary> | |||
| [Obsolete (""(Version: 2.9.4) If you need to track when an object gains or | |||
There was a problem hiding this comment.
I wasn't sure how we wanted this to look, but I figured we could fix up the formatting later
decriptor
force-pushed
the
interface-work
branch
from
4ffb7db to
bf939cb
Compare
|
Good work! I didn't have time to report the "I" interface prefix as an issue :D |
Fixes #35
doc-deprecatedtextProblems
Typeset so you getstatic void Append ( array, guint8 data, guint len);doc-deprecatedmessage