This repository was archived by the owner on Nov 3, 2023. It is now read-only.
Add comments #40
Merged
Add comments #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundermann
previously approved these changes
Mar 2, 2018
| @@ -50,6 +50,16 @@ static void GenerateImport (this ICallable callable, IGeneratable parent, Indent | |||
| var retType = GetReturnCSharpType (callable, writer); | |||
|
|
|||
| var (typesAndNames, names) = BuildParameters (callable, writer.Options, appendInstanceParameters: true); | |||
|
|
|||
| // TODO: Better than using the constant string, insert a custom generatable which contains the import string as a constant. | |||
| // Also, glib-2.0.gir is problematic, it contains 2 library names :( | |||
There was a problem hiding this comment.
Usually everything is in the first specified library
There was a problem hiding this comment.
I think I even talked about that issue with the gi devs and they said the same.
There was a problem hiding this comment.
Cool, we can do that.
decriptor
reviewed
Mar 2, 2018
src/Gir/Generation/Callback.cs
Outdated
| // Public API delegate which uses managed types. | ||
| writer.WriteLine ("[UnmanagedFunctionPointer (CallingConvention.Cdecl)]"); | ||
| writer.WriteLine ($"public delegate {returnType} {Name} PARAMS"); | ||
| writer.WriteLine (); |
There was a problem hiding this comment.
There was a problem hiding this comment.
I wrote this for now, need to hack out the import definition out of ICallable
There was a problem hiding this comment.
And a callback is not really a member, it's a type.
decriptor
previously approved these changes
Mar 2, 2018
|
Should be better now. |
decriptor
approved these changes
Mar 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.