This repository was archived by the owner on Nov 3, 2023. It is now read-only.
More implementation #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Therzok
reviewed
Mar 3, 2018
| @@ -3,7 +3,6 @@ | |||
|
|
|||
| namespace Gir | |||
| { | |||
| [Serializable] | |||
Therzok
reviewed
Mar 3, 2018
| @@ -3,7 +3,6 @@ | |||
|
|
|||
| namespace Gir | |||
| { | |||
| [Serializable] | |||
There was a problem hiding this comment.
Why remove the serializables here?
There was a problem hiding this comment.
It was only on 3 files and doesn't appear to be needed. I was just going for consistency
Therzok
reviewed
Mar 3, 2018
| @@ -16,7 +16,7 @@ public static string ToCSharp (this string cname) | |||
|
|
|||
| bool isUpper = true; | |||
| foreach (var c in cname) { | |||
| if (c == '_') { | |||
| if (c == '_' || c == '-') { | |||
Because we are changing the element's Namespace in the case of Signal or glib:signal we have to reset it back to: http://www.gtk.org/introspection/core/1.0 for signal's elements
decriptor
force-pushed
the
more-implementation
branch
from
dfbb22c to
79faf51
Compare
Therzok
approved these changes
Mar 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.