Add support for gtk2 gir files #54
Conversation
| if (Deprecated) | ||
| writer.WriteLine ($"[Obsolete (\"(Version: {DeprecatedVersion}) {DocDeprecated.Text}\")]"); | ||
|
|
||
| if (!string.IsNullOrEmpty (Deprecated)) { |
There was a problem hiding this comment.
Which gobject-introspection version was used for these files? This might happen if the gi-scanner is too old and the gir format has changed.
There was a problem hiding this comment.
The version claimed to be the same gir format version
| [TestFixture] | ||
| public abstract class GenerationGtk2TestBase | ||
| { | ||
| protected const string Gdk2 = "Gtk2.Gdk-2.0"; |
There was a problem hiding this comment.
Why not just add them into the generation test base?
There was a problem hiding this comment.
I started to do that, but the include directory is different. Might be worth merging them back together?
There was a problem hiding this comment.
We can probably infer the include directory from the name? i.e. Gtk2.Gdk-2.0 -> include Gtk2, load Gdk-2.0.
src/Gir/Generation/Method.cs
Outdated
| writer.WriteLine ($"[Obsolete (\"(Version: {DeprecatedVersion}) {DocDeprecated.Text}\")]"); | ||
|
|
||
| if (!string.IsNullOrEmpty (Deprecated)) { | ||
| if (Deprecated == "0") { |
There was a problem hiding this comment.
if (Deprecated == "1") -> obsolete version
else if (Deprecated != "0") -> obsolete
decriptor
force-pushed
the
gtk2-gir-files
branch
from
a11e991 to
5bbd0a7
Compare
Instead of Deprecated being a bool it was used as the deprecation message.
decriptor
force-pushed
the
gtk2-gir-files
branch
from
56c9278 to
f71d3c4
Compare
Instead of blindly parsing all of the available gir files we now specify a specific library. In particular we are avoiding mixing gtk2 and gtk3 gir files.
Instead of Deprecated being a bool it was used as the deprecation
message.