Skip to content
This repository was archived by the owner on Nov 3, 2023. It is now read-only.

Struct layoutkind #66

Merged
merged 2 commits into from
Jul 25, 2018
Merged

Struct layoutkind #66

merged 2 commits into from
Jul 25, 2018

Conversation

sundermann
Copy link
Collaborator

No description provided.

decriptor
decriptor reviewed Jul 25, 2018
View reviewed changes
src/Gir/Generation/IndentWriter.cs
@@ -28,6 +28,7 @@ public IndentWriter WriteHeader ()
return this;

WriteLine ("using System;");
WriteLine ("using System.Runtime.InteropServices;");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add this to every file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In almost every file. All structs will need the LayoutKind attribute and we will need the Marshal class quite often. I think it's worth it to include it in any file rather than checking if we really need it. The old generator included it in any file as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @stsundermann

@sundermann
Copy link
Collaborator Author

Seems like jenkins failed for some reason. Tests run fine on my machine though

@decriptor
Copy link
Contributor

I think jenkins is busted for this build.

@Therzok
Copy link
Contributor

Therzok commented Jul 25, 2018

Jenkins is busted all around. Not sure what's up. cc @directhex

@Therzok
Copy link
Contributor

Therzok commented Jul 25, 2018 

java.lang.UnsupportedOperationException: no known implementation of class org.jenkinsci.lib.dtkit.type.TestType is named NUnit3JunitHudsonTestType
	at org.jenkinsci.plugins.structs.describable.DescribableModel.resolveClass(DescribableModel.java:449)
	at org.jenkinsci.plugins.structs.describable.DescribableModel.coerce(DescribableModel.java:401)
	at org.jenkinsci.plugins.structs.describable.DescribableModel.coerceList(DescribableModel.java:485)
	at org.jenkinsci.plugins.structs.describable.DescribableModel.coerce(DescribableModel.java:413)
	at org.jenkinsci.plugins.structs.describable.DescribableModel.buildArguments(DescribableModel.java:340)
	at org.jenkinsci.plugins.structs.describable.DescribableModel.instantiate(DescribableModel.java:281)

@Therzok
Copy link
Contributor

Therzok commented Jul 25, 2018

build

@Therzok Therzok merged commit 9fe50b3 into master Jul 25, 2018
@Therzok Therzok deleted the struct-layoutkind branch July 25, 2018 18:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@decriptor decriptor decriptor left review comments

@Therzok Therzok Therzok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sundermann @decriptor @Therzok