-
Notifications
You must be signed in to change notification settings - Fork 58
ci: re-enabled intel build pipeline #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe GitHub Actions workflow configuration was updated to add the "intel" platform to the build matrix for the "build-and-push" job. This change ensures that the continuous integration process now includes building and pushing images for the "intel" platform alongside the existing platforms. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant GitHub Actions
participant Build System
Developer->>GitHub Actions: Push code / open PR
GitHub Actions->>Build System: Trigger build-and-push for each platform (cuda, vulkan, cpu, musa, intel)
Build System-->>GitHub Actions: Build and push images for all platforms including intel
GitHub Actions-->>Developer: Report build status for all platforms
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/containers.yml (1)
18-18
: Consider switching to a block-style YAML list for matrix platforms.Using a block-style list can improve readability and make diffs cleaner when adding or removing entries:
strategy: matrix: platform: - intel - cuda - vulkan - cpu - musa
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/containers.yml
(1 hunks)
🔇 Additional comments (1)
.github/workflows/containers.yml (1)
18-18
: Verify build script compatibility with the newintel
target.You’ve added
intel
back into the build matrix, but please confirm that./docker/build-container.sh
(and any underlying Docker Buildx/platform mappings) correctly recognize and handle"intel"
as a platform key. Run a CI trial or smoke test to ensure image builds and pushes for theintel
target succeed without errors.
Intel build pipeline has been unclogged, container images now published without
out of space
errorref:
free_disk_space
flag enabled for intel variant ggml-org/llama.cpp#13426Summary by CodeRabbit