-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[charts-premium] Add initial package for x-charts-premium
#18331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Deploy preview: https://deploy-preview-18331--material-ui-x.netlify.app/ Updated pages: Bundle size reportTotal Size Change: 0B(0.00%) - Total Gzip Change: 0B(0.00%) Show details for 100 more bundles (22 more not shown)@mui/x-charts parsed: 0B(0.00%) gzip: 0B(0.00%) |
CodSpeed Performance ReportMerging #18331 will not alter performanceComparing Summary
|
|
||
## Documentation | ||
|
||
Visit [https://mui.com/x/react-charts/](https://mui.com/x/react-charts/) to view the full documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is there already, isn't it done by this component? https://github.com/mui/mui-x/pull/18331/files#diff-78ebd4adb67b0ab5d013a8c9cf2473c4680a1267bf31f4af257b18d5bba08200
// exports from MIT package | ||
export * from '@mui/x-charts/constants'; | ||
export * from '@mui/x-charts/context'; | ||
export * from '@mui/x-charts/hooks'; | ||
export * from '@mui/x-charts/colorPalettes'; | ||
export * from '@mui/x-charts/models'; | ||
export * from '@mui/x-charts/ChartsClipPath'; | ||
export * from '@mui/x-charts/ChartsReferenceLine'; | ||
export * from '@mui/x-charts/ChartsAxis'; | ||
export * from '@mui/x-charts/ChartsXAxis'; | ||
export * from '@mui/x-charts/ChartsYAxis'; | ||
export * from '@mui/x-charts/ChartsGrid'; | ||
export * from '@mui/x-charts/ChartsText'; | ||
export * from '@mui/x-charts/ChartsTooltip'; | ||
export * from '@mui/x-charts/ChartsLegend'; | ||
export * from '@mui/x-charts/ChartsLocalizationProvider'; | ||
export * from '@mui/x-charts/ChartsAxisHighlight'; | ||
export * from '@mui/x-charts/BarChart'; | ||
export * from '@mui/x-charts/LineChart'; | ||
export * from '@mui/x-charts/PieChart'; | ||
export * from '@mui/x-charts/ScatterChart'; | ||
export * from '@mui/x-charts/SparkLineChart'; | ||
export * from '@mui/x-charts/Gauge'; | ||
export * from '@mui/x-charts/RadarChart'; | ||
export * from '@mui/x-charts/ChartsSurface'; | ||
export * from '@mui/x-charts/ChartDataProvider'; | ||
export * from '@mui/x-charts/ChartsLabel'; | ||
export type { | ||
ZoomData, | ||
ZoomFilterMode, | ||
ZoomSliderShowTooltip, | ||
ZoomOptions, | ||
ZoomSliderOptions, | ||
} from '@mui/x-charts/internals'; | ||
|
||
// Pro components | ||
export * from '@mui/x-charts-pro/hooks'; | ||
export * from '@mui/x-charts-pro/Heatmap'; | ||
export * from '@mui/x-charts-pro/ChartContainerPro'; | ||
export * from '@mui/x-charts-pro/ChartDataProviderPro'; | ||
export * from '@mui/x-charts-pro/ScatterChartPro'; | ||
export * from '@mui/x-charts-pro/BarChartPro'; | ||
export * from '@mui/x-charts-pro/LineChartPro'; | ||
export * from '@mui/x-charts-pro/PieChartPro'; | ||
export * from '@mui/x-charts-pro/FunnelChart'; | ||
export * from '@mui/x-charts-pro/RadarChartPro'; | ||
export * from '@mui/x-charts-pro/ChartZoomSlider'; | ||
export * from '@mui/x-charts-pro/ChartsToolbarPro'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I''m wondering if this would be the same
// exports from MIT package | |
export * from '@mui/x-charts/constants'; | |
export * from '@mui/x-charts/context'; | |
export * from '@mui/x-charts/hooks'; | |
export * from '@mui/x-charts/colorPalettes'; | |
export * from '@mui/x-charts/models'; | |
export * from '@mui/x-charts/ChartsClipPath'; | |
export * from '@mui/x-charts/ChartsReferenceLine'; | |
export * from '@mui/x-charts/ChartsAxis'; | |
export * from '@mui/x-charts/ChartsXAxis'; | |
export * from '@mui/x-charts/ChartsYAxis'; | |
export * from '@mui/x-charts/ChartsGrid'; | |
export * from '@mui/x-charts/ChartsText'; | |
export * from '@mui/x-charts/ChartsTooltip'; | |
export * from '@mui/x-charts/ChartsLegend'; | |
export * from '@mui/x-charts/ChartsLocalizationProvider'; | |
export * from '@mui/x-charts/ChartsAxisHighlight'; | |
export * from '@mui/x-charts/BarChart'; | |
export * from '@mui/x-charts/LineChart'; | |
export * from '@mui/x-charts/PieChart'; | |
export * from '@mui/x-charts/ScatterChart'; | |
export * from '@mui/x-charts/SparkLineChart'; | |
export * from '@mui/x-charts/Gauge'; | |
export * from '@mui/x-charts/RadarChart'; | |
export * from '@mui/x-charts/ChartsSurface'; | |
export * from '@mui/x-charts/ChartDataProvider'; | |
export * from '@mui/x-charts/ChartsLabel'; | |
export type { | |
ZoomData, | |
ZoomFilterMode, | |
ZoomSliderShowTooltip, | |
ZoomOptions, | |
ZoomSliderOptions, | |
} from '@mui/x-charts/internals'; | |
// Pro components | |
export * from '@mui/x-charts-pro/hooks'; | |
export * from '@mui/x-charts-pro/Heatmap'; | |
export * from '@mui/x-charts-pro/ChartContainerPro'; | |
export * from '@mui/x-charts-pro/ChartDataProviderPro'; | |
export * from '@mui/x-charts-pro/ScatterChartPro'; | |
export * from '@mui/x-charts-pro/BarChartPro'; | |
export * from '@mui/x-charts-pro/LineChartPro'; | |
export * from '@mui/x-charts-pro/PieChartPro'; | |
export * from '@mui/x-charts-pro/FunnelChart'; | |
export * from '@mui/x-charts-pro/RadarChartPro'; | |
export * from '@mui/x-charts-pro/ChartZoomSlider'; | |
export * from '@mui/x-charts-pro/ChartsToolbarPro'; | |
export * from '@mui/x-charts-pro' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually we would have to do the extensive one to remove things like BarChartPro
if we have BarChartPremium
no?
packages/x-charts-pro/.mocharc.js
Outdated
@@ -1,34 +0,0 @@ | |||
// We can't import the `.mocharc.js` of the monorepo, otherwise we trigger its `setupBabel`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assuem this is not related to premium, but to the vite test migration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I merged that in another pr, will be gone by the time we merge this 😆
Co-authored-by: Alexandre Fauquette <[email protected]> Signed-off-by: Jose C Quintas Jr <[email protected]>
TODO: CHARTS-PREMIUM:
to logic that can be enabled when premium go live