[charts][draft] Explore selector typing #18362
Conversation
alexfauquette
commented
Jun 13, 2025
alexfauquette
commented
- I have followed (at least) the PR section of the contributing guide.
|
Deploy preview: https://deploy-preview-18362--material-ui-x.netlify.app/ Bundle size reportTotal Size Change: 🔺+2.13KB(+0.02%) - Total Gzip Change: ▼-2.02KB(-0.05%) Show details for 100 more bundles (22 more not shown)@mui/x-charts-pro/FunnelChart parsed: 🔺+391B(+0.19%) gzip: 🔺+30B(+0.04%) |
alexfauquette
added
typescript
scope: charts
CodSpeed Performance ReportMerging #18362 will degrade performances by 14.6%Comparing Summary
Benchmarks breakdown
|
|
This seems to work, but we're ditching Looking at |
It is generic though, it is typecast with We could try to manually make it generic with our own typings, or we could try to make the type required, so whoever is calling the createSelector has to type the expected params/return. |
|
I tried importing a simpler version of |
| Map<Parameters<typeof reselectCreateSelector>, any> | ||
| Map< | ||
| [ | ||
| inputSelectors: [...SelectorArray<any>], |
There was a problem hiding this comment.
Isn't this enough?
| inputSelectors: [...SelectorArray<any>], | |
| inputSelectors: SelectorArray<any>, |
Same in line 72.
| const xAxisFilter = | ||
| zoomMap && | ||
| zoomOptions && | ||
| createAxisFilterMapper({ | ||
| zoomMap, | ||
| zoomOptions, | ||
| seriesConfig, | ||
| formattedSeries, | ||
| direction: 'x', | ||
| }); | ||
| const yAxisFilter = | ||
| zoomMap && | ||
| zoomOptions && | ||
| createAxisFilterMapper({ | ||
| zoomMap, | ||
| zoomOptions, | ||
| seriesConfig, | ||
| formattedSeries, | ||
| direction: 'y', | ||
| }); | ||
|
|
||
| const getFilters = getZoomAxisFilters(xAxisFilter, yAxisFilter, xAxis, yAxis); |
There was a problem hiding this comment.
This change doesn't seem related to fixing types. Is it fixing something?
