Skip to content

token service refactoring #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

cfaur09
Copy link
Contributor

@cfaur09 cfaur09 commented Apr 9, 2025

Reasoning

  • token.service is to complex with multiple functionalities

Proposed Changes

  • separate functionalities into multiple services
  • add TokenPriceService

How to test

@cfaur09 cfaur09 marked this pull request as draft April 9, 2025 12:01
Copy link

github-actions bot commented Apr 9, 2025

k6 load testing comparison.
Base Commit Hash: eb1ec37
Target Commit Hash: 3a11817

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Accounts51.041163.9955.0256.9648.72926.6451.9554.34-4.55% ✅-20.39% ✅-5.58% ✅-4.61% ✅
Blocks63.452079.2655.6858.7259.501032.4266.3776.54-6.22% ✅-50.35% ✅+19.20% 🔴+30.35% 🔴
Mex50.03565.9754.8256.9047.65198.9551.9654.34-4.76% ✅-64.85% ✅-5.22% ✅-4.49% ✅
Nodes50.45800.3454.8956.9849.061330.0952.0654.41-2.75% ✅+66.19% 🔴-5.14% ✅-4.51% ✅
Transactions65.201754.2155.7158.8262.241729.4273.3778.38-4.54% ✅-1.41% ✅+31.71% 🔴+33.27% 🔴
Pool50.11536.9254.8256.9047.89520.2051.9454.32-4.43% ✅-3.11% ✅-5.25% ✅-4.54% ✅
Tokens49.93572.7554.8856.9048.16551.4252.0154.37-3.56% ✅-3.72% ✅-5.22% ✅-4.45% ✅
Test Run Duration60001.8860001.99

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

@cfaur09 cfaur09 changed the title add TokenPriceService token service refactoring Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant