Updated to scorecards for 2025 site #724
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makes it easier to update, plus easier to have staging site use different year
fix incorrect heading names fix some bad score data
If it's the current year then link to the url without the year prefix, otherwise add year prefix.
also get this to respect the currently selected year
- Added some responsiveness improvements for tablet and screens below 1200px. Council comparison won't be display below a large screen. - Added Previous year score checkbox, by default we will only display year variation, but this switch will allow to also display the previous year score for current council and any council we are comparing with.
Was running a query for every question to get the criteria and then one for every section to get the council so make sure those things are fetched in the initial query
To make this element more reusable I have added the class js-table-year-comparison so instead of tackling specifically tables like the council one it tackles tables with the class js-table-year-comparison
Rather than selecting it based on council and year we can just create a link on import which makes things easier
e.g for the first year's scorecards
Also make config per year
for labeling the most improved councils on import, and then for generating graphics etc Also add plan scores to admin interface
Does this for overall per council type and overall per section
Also put things in a per year folder
zarino
reviewed
Mar 10, 2025
| @@ -11,8 +11,18 @@ | |||
| import socket | |||
| from datetime import date | |||
|
|
|||
| import environ | |||
There was a problem hiding this comment.
Note: I’m getting ModuleNotFoundError: No module named 'environ' even after running script/build.
There was a problem hiding this comment.
Huh, odd. If I rebuild and run it's fine. And the module is in pyproject.toml so it should be installed. Not quite sure how to resolve this given I can't replicate it.
easier to update in the database rather than the settings file
this is mostly to stop annoying error emails on staging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly small changes to allow multiple years of actions scores.
Part of #645
Fixes #722
Fixes #723