Skip to content

[Scorecards ]Added Year Comparison to Homepage #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 23 commits into
base: 2025-scorecards
Choose a base branch
from
Draft

[Scorecards ]Added Year Comparison to Homepage #730

wants to merge 23 commits into from

Conversation

lucascumsille
Copy link
Contributor

@lucascumsille lucascumsille commented Feb 18, 2025 •
edited
Loading

  • Get rid z-index-3 with Bootstrap 5 default classes. Same for 4 and 5
  • For the difference legends. I need to know the possible outliner scenarios, like "Council didn't exist in 2023".
  • Get rid of #ff000c color for the legends
  • What are we going to do with the sorting. Currently is only sorting the table by the current year score, do we want to sort by previous year and difference?
  • Optimise the top performer hover message
  • Make consistent the score progress bars between mobile and desktop
  • Change the progress bar to use pale version of color instead of the bold one.
  • Add changes to Combined Authorities
  • Add instructions to Struan
  • Review if the scope for cell are correct

Mobile

  • Jump to council is not working on mobile
  • Enable be able to select a different category other than Total score.

@struan struan force-pushed the year-comparison-council-section-table branch from 9d5cd17 to 5c51cbd Compare February 18, 2025 17:57
@lucascumsille lucascumsille force-pushed the year-comparison-homepage branch 3 times, most recently from fa1985e to c85787f Compare February 19, 2025 09:32
@struan struan force-pushed the year-comparison-council-section-table branch from 5c51cbd to 446843e Compare February 19, 2025 13:55
@lucascumsille lucascumsille force-pushed the year-comparison-homepage branch 11 times, most recently from fceaeec to 675c233 Compare February 26, 2025 09:46
@struan struan force-pushed the year-comparison-council-section-table branch from cba38d3 to 097b9c0 Compare March 3, 2025 13:55
@lucascumsille lucascumsille force-pushed the year-comparison-homepage branch from 1828ebc to 77437b6 Compare March 4, 2025 14:55
@lucascumsille lucascumsille changed the base branch from year-comparison-council-section-table to 2025-scorecards March 4, 2025 14:58
@lucascumsille lucascumsille force-pushed the year-comparison-homepage branch 9 times, most recently from 17a6e1b to ec3e0ed Compare March 5, 2025 14:12
@lucascumsille
Copy link
Contributor Author

@struan I just finished pushing commit to this branch. It also included the latest feedback from CEUK, let me know if you need a walkthrough =)

@struan struan force-pushed the year-comparison-homepage branch from ec3e0ed to e43e9a6 Compare March 5, 2025 14:44
lucascumsille and others added 18 commits March 17, 2025 16:46
@lucascumsille @struan
[Scorecards] Increased contrast for text-success
e815136
@lucascumsille @struan
[Scorecards] Improve legibility of homepage table numbers
8cf421c
@lucascumsille @struan
[Scorecards] Moved common table styles to tables.scss
e3078ff
@lucascumsille @struan
[Scorecards] Change homepage mobile table breakpoint.
304a93d 
It uses Bootstrap large screen instead of random number.
@lucascumsille @struan
[Scorecards] Added year comparison to homepage
9d89949
@lucascumsille @struan
[Scorecards] Added category selector for mobile table
02a58a7
@lucascumsille @struan
Added link icon
b343a7f
@lucascumsille @struan
[Scorecards] Added Year comparison for Homepage mobile version
40a3106
@lucascumsille @struan
[Scorecards] Added Fix to homepage advanced filters
b30ef88 
- Improved layout on mobile so filters always use 2 items per row.
- Advanced filters are now functional on mobile
@lucascumsille @struan
[Scorecards] Improved top-performer message
91bec0b 
- Instead of creating new classes it uses Bootstrap 5 default tooltip
@lucascumsille @struan
[Scorecards] Added 2025 Front end to CA homepage
538738e
@struan
[Scorecards] add working previous year data to front page
da98ba4
@struan
[Scorecards] include previous year total avg in get averages
9e6a32d
@struan
[Scorecards] allow get_all_councils_scores to return a list
fa8d575 
Allows for a bit less repetition in the templates
@struan
[Scorecards] get averages as a list and use in template
82a30d2 
Much less code repetition. Also cut down on the number of templates
included
@struan
[Scorecards] fill in details for mobile front page
f0bc67c
@struan
[Scorecards] update homepage for years with no previous years
3572496 
Also do some removal of repeated code
@struan
[Scorecards] no long need separate combined homepage template
3b76dd6
@struan struan force-pushed the year-comparison-homepage branch from 1e3eff7 to 3b76dd6 Compare March 17, 2025 16:46
@struan struan force-pushed the 2025-scorecards branch from 226a90d to f1f5490 Compare April 7, 2025 09:35
@struan struan force-pushed the 2025-scorecards branch from afee1c9 to 4999c09 Compare May 13, 2025 10:54
lucascumsille and others added 5 commits May 19, 2025 13:52
@lucascumsille
[Scorecards] Added missing 's' on exist
7c93a4f
@lucascumsille
[DELETE] momentarily change to settings.py
fb8dd2c
@lucascumsille
[Scorecards] Updated harcoded is--category-x
e0e5b35 
Now it will use {{ forloop.counter }} so the sorting icons match the category colour.
@lucascumsille
[Scorecards] Added alignment fix for headings in homepage
563de7a 
Added a fix when the users deactivate 'Display percentage point change' so the aligment goes from center to left.
@struan
[scorecards] remove decimal places in change numbers on front page
044b6ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucascumsille @struan