Skip to content

[Scorecards] Added year comparison question page #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: 2025-scorecards
Choose a base branch
from

Conversation

lucascumsille
Copy link
Contributor

@lucascumsille lucascumsille commented Mar 6, 2025

  • Confirm what will do with questions that have change their maximum scores between 2023 and 2025. My guess is we should't show any difference. Instead let's display a message below the overview cards explaining why there is no comparison.

Desktop

Screen.Recording.2025-03-10.at.08.50.49.mov

Mobile

Screen.Recording.2025-03-10.at.09.16.52.mov

easier to update in the database rather than the settings file
@lucascumsille lucascumsille force-pushed the year-comparison-question-table-v2 branch 2 times, most recently from f310ad9 to 56b8fc3 Compare March 6, 2025 07:34
@lucascumsille lucascumsille changed the base branch from master to 2025-scorecards March 6, 2025 07:34
@lucascumsille lucascumsille force-pushed the year-comparison-question-table-v2 branch 8 times, most recently from 18af5b1 to 097d45d Compare March 10, 2025 09:16
@lucascumsille
Copy link
Contributor Author

lucascumsille commented Mar 10, 2025

@struan I think we are ready with the question page, but if you prefer we could wait for tomorrow, however this is the same version CEUK gave the approval last week.
I need to double check with them tomorrow how we will handle when a question has changed its maximum score from one year to another and also when is a new question. At the moment I have added two messages that should handle both scenarios, but I'll check with them tomorrow. I think in worst case scenario the copy will change.

@lucascumsille
Copy link
Contributor Author

@struan, in our call with CEUK today, they suggested there might be questions where they wouldn't want a comparison between years, and it won't be a matter of "New question". Some questions changed their criteria quite a bit, and they probably don't want those questions to be compared, so they were asking if there is a way to tackle cases like that.

Regarding the scenario where the "maximum score" changes between years, they haven't decided whether to use the grey message advising users about the score changes. I'll check with them again.

Besides the above, we can move ahead with this branch.

- Improved hierarchy for titles.
- Limit the width for h1 question title in hero section.
- Decreased font-size for question title in hero section.
- Fix indentation to 4 spaces
- Fixes tooltip for Question weight in hero section.
@struan struan force-pushed the year-comparison-question-table-v2 branch 2 times, most recently from f2908c1 to 45c62ce Compare March 12, 2025 16:27
@struan struan force-pushed the year-comparison-question-table-v2 branch from 45c62ce to dffaa0e Compare March 12, 2025 16:52
@struan struan force-pushed the 2025-scorecards branch from 226a90d to f1f5490 Compare April 7, 2025 09:35
@zarino zarino linked an issue May 12, 2025 that may be closed by this pull request
@struan struan force-pushed the 2025-scorecards branch from afee1c9 to 4999c09 Compare May 13, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[scorecards] Cross-year comparisons on the 2025 Question pages
2 participants