Changes to allow deployment of WTT onto Debian Bookworm #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagepe
changed the title
|
Just going to tidy up mysociety/commonlib#92 and get the final version of that included here and will merge. |
This is no longer supported in PHP 8.x. See: https://www.php.net/manual/en/migration80.incompatible.php
This removes the apostrophes from one of the test strings as these were being escaped and the search in the the web output wasn't matching as a result. We may want to fix the escaping issue but I wanted to start off getting the major incompatibilities sorted.
The most recent version of Crypt::CBC handles passphrases a bit differently so we need to alter the code to make sure that tokens generated using the old version are compatible with the new one.
Handles new lines in the reply to
When displayed apostrophes are escaped so we need to take the message and HTML escape it before comparing with the output.
Since PHP 8.0, calls to join() no longer support passing the array followed by the separator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates out the commits needed for the Debian Bookworm deploy from #504 so that we can deploy this first before adding the new functionality.