#2301 Unable to set minimum TLS version

[alexburley]

#2301

Since Node 9 and before don't support min/max version these won't be set and the tests won't fail for those versions.

Node default TLS version is set to 1.2 for tests as Node 10 has not enabled support for 1.3 by default.

Tested against mysql 5.5 and mysql 8 servers

[dougwilson]

Awesome job! I just saw a couple things in tests I noted here. Please note that nothing here to me is at a level where I won't do anything until you do something; I will liekly work on the changes in here this weekend if you don't get to them first. But if you can get to them earlier, it's that much easier & faster for me to get landed ❤️

[alexburley]

@dougwilson Thx for review 👍 Making some ammendments now, not sure if I understand what you mean about how i'm generating the test SSL config

[alexburley]

@dougwilson Any luck? Sorry to keep badgering, I just want to make sure I can update our service and get it running on Node12 before I forget.

[alexburley]

@dougwilson Any update on when this can be merged?

[antonisa-proto]

Hello,
Can anyone review this PR @alexburley @dougwilson ? It seems that a lot of people have the same problem and this PR is going to solve it!

[dougwilson]

Sorry this fell off my radar. Thanks for the ping I will push it forward tonight

[rathboma]

Just found this -- excited to see the work done already!

It has come up as an issue with our mysql integration in Beekeeper Studio. Think it's the cause of beekeeper-studio/beekeeper-studio#254

@dougwilson thanks so much for helping to get this merged. @alexburley thanks for doing the work!

[dougwilson]

Apologies for letting this languish. I have rebased this, adjusted the tests a bit, and eve found there was a race condition, which is why the original tests in the PR had a behavior difference between Node.js 10.x and 11.x+, which is fixed now as well.