Added isConnected method to Connection.js #2341
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougwilson
reviewed
Apr 24, 2020
|
I have worked on diverse tools for development (PHP,Java,C#) and isConnected() method is a common perception in db drivers to be used for check whether the connection is still connected. I was working on some other project today and found it missing so i added |
|
Thank you, that is very appreciated. I appreciate that other tools have differing APIs, and acknowledge that each project can have it's own opinion as to what type of API it should present to the user. |
|
Sure , thank you for your time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added isConnected() method to Connection.js . Now its easy to check whether you are connected to database or not.