Skip to content

Fix/error suppress #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fix/error suppress #2384

wants to merge 4 commits into from

Conversation

imanshugupta
Copy link

I have a minor change in mysql library which prevents app crashes while using it with nodejs.
Connection.prototype._handleProtocolError = function(err) { this.state = 'protocol_error'; try { this.emit('error', err); } catch(err) { } };

@dougwilson
Copy link
Member

Hi @imanshugupta this is a branch I created that is not ready to be merged, as indicated by the fixup! commits still in there and the failing CI. Generally you should only create a pull request from your own branch rather than from others', as you may not always be aware of the state of the code and liekly won't have any permissions to push changes as part of the review process.

I see this is the second time you've opened a pull request off the same branch. You may be struggling to use GitHub, perhaps. I'm not sure what you're trying to do, but you can find help on how to use GitHub at https://docs.github.com/

@dougwilson dougwilson closed this Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants