App crashing fix due to protocol error #2385
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protocol error emits error event which is not properly handleled which causes node app crash. Its a preventation of app crash
dougwilson
requested changes
Aug 10, 2020
There was a problem hiding this comment.
Thank you for your pull request! Please be sure to update this by following the steps outlined in https://github.com/mysqljs/mysql#contributing like the following:
- Try to include a clear description of your pull request in the description. It should include the basic "what" and "why"s for the request.
- The pull request should include tests for the change. A new feature should have tests for the new feature and bug fixes should include a test that fails without the corresponding code change and passes after they are applied. The command npm run test-cov will generate a coverage/ folder that contains HTML pages of the code coverage, to better understand if everything you're adding is being tested.
- If the pull request is a new feature, please be sure to include all appropriate documentation additions in the Readme.md file as well.
- To help ensure that your code is similar in style to the existing code, run the command npm run lint and fix any displayed issues.
|
Closing due to no follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protocol error emits error event which is not properly handleled which causes node app crash.
Its a preventation of app crash