FIx redraw mechanism to be based on buffer and not viewport #913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when to redraw was statically set to 0.5x the displayed interval. Most likely this is a bug as it should redraw when only half of the configured buffer size remains outside the viewport.
|
This is obviously not maintained, so I'm going ahead and closing this :) |
|
Hi @LudvigHz, we released a new version with updated dependencies. Please feel free to test out the new version and reopen this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates node-sass to latest version to support newer node versions.
The README states that the canvas should redraw when there is 1/2 of the buffer left off-screen on any side of the viewport. However, the code calculates the redraw based on 1/2 of the viewport and not the buffer. This PR fixes this. This means that for buffers larger than the default, we re-render way less often, providing for better performance with large timelines. As it is now, for many tasks (~1000) the canvas continuously re-renders when scrolling, and the rendering cannot keep up with scrolling, forcing the items to appear as they jump around a lot.
I don't know if this repo is actively maintained, but we will use our own fork (NPM) as long as this PR is open and the repo appears unmaintained.