Skip to content

Update package.json to use .cjs extension #1 #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2025

Conversation

visormatt
Copy link
Contributor

@visormatt visormatt commented Feb 5, 2025

Issue Number

I wasn't able to find a bug around this exact issue so we're just fixing it quickly.

Overview of PR

The main and exports.require are incorrect and pointing to .umd.js files that are actually being build out as .cjs.js files.

  • The current package.json references two .umd.js extensions
  • Actual dist files are .cjs extensions, there are no .umd files built

package
dist

The current mappings are incorrect and point to two `.umd.js` files that are actually being build out as `.cjs.js` files.
Copy link
Collaborator

@Ilaiwi Ilaiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Ilaiwi Ilaiwi merged commit d93ab1f into namespace-ee:master Feb 16, 2025
@visormatt visormatt deleted the patch-1 branch February 16, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants