Fix online reps weight sampling

[pwojcikdev]

No description provided.

[gr0vity-dev-bot]

Test Results for Commit a77d37b

Pull Request 4927: Results
Overall Status: ✅

Test Case Results

• ✅ 5n4pr_conf_10k_bintree: PASS (Duration: 111s)
• ✅ 5n4pr_conf_10k_change: PASS (Duration: 123s)
• ✅ 5n4pr_conf_change_dependant: PASS (Duration: 129s)
• ✅ 5n4pr_conf_change_independant: PASS (Duration: 133s)
• ✅ 5n4pr_conf_send_dependant: PASS (Duration: 118s)
• ✅ 5n4pr_conf_send_independant: PASS (Duration: 171s)
• ✅ 5n4pr_rocks_10k_bintree: PASS (Duration: 107s)
• ✅ 5n4pr_rocks_10k_change: PASS (Duration: 143s)

Last updated: 2025-07-12 08:13:15 UTC

[Copilot]

Pull Request Overview

This PR refactors how online representative weights are recalculated and sampled over time, ensuring updates happen both on new observations and within the background loop.

• Encapsulate online weight updates in a new update_online() method and invoke it in both observe() and the run() loop.
• Introduce last_sample timestamp in online_reps.hpp to gate trended weight sampling by weight_interval.
• Update existing tests to use timed assertions and add a new test verifying online weight recalculation when a representative’s delegated weight changes.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
nano/node/online_reps.hpp	Added update_online() method and last_sample member for sampling
nano/node/online_reps.cpp	Implemented update_online(), adjusted run() loop timing and logic
nano/core_test/online_reps.cpp	Switched to ASSERT_TIMELY_EQ and added weight_change_recalculation test
nano/core_test/node.cpp	Introduced local delta variable in test and updated related asserts

Comments suppressed due to low confidence (1)

nano/node/online_reps.hpp:103

• [nitpick] Consider adding a brief comment to explain that last_sample tracks the timestamp of the last trended weight collection, improving readability and maintenance.

	std::chrono::steady_clock::time_point last_sample;