Explicitly specify Tspan in PL*Noise components
#1908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The ipynb files are just re-blackened. They don't have any actual change. |
abhisrkckl
added
the
awaiting review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1908 +/- ##
=======================================
Coverage 69.88% 69.89%
=======================================
Files 110 110
Lines 25695 25656 -39
Branches 4058 4054 -4
=======================================
- Hits 17956 17931 -25
+ Misses 6601 6592 -9
+ Partials 1138 1133 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dlakaplan
reviewed
Jun 5, 2025
src/pint/models/noise_model.py
Outdated
| ) | ||
| ) | ||
| self.add_param( | ||
| floatParameter( | ||
| name="TNDMFLOG_FACTOR", | ||
| units="", | ||
| description="Factor of the log-spaced DM frequencies (2 -> [1/8,1/4,1/2,...])", | ||
| convert_tcb2tdb=False, | ||
| description="Factor of the log-spaced DM frequencies (2 -> [1/8, 1/4, 1/2, ...]).", |
There was a problem hiding this comment.
Maybe "Factor for" rather than "Factor of"?
dlakaplan
reviewed
Jun 5, 2025
src/pint/models/noise_model.py
Outdated
| floatParameter( | ||
| name="TNDMTSPAN", | ||
| units="year", | ||
| description="Time span corresponding to the fundamental frequency of the DM noise Fourier series.", |
There was a problem hiding this comment.
Should this comment have "Tspan if None" or similar?
|
This looks good, except I have a few minor comments related to the comment strings. |
|
Is this ready? |
|
Yes |
This was referenced Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.