add deployment function #3618

chuynh4duarte · 2025-05-14T23:13:09Z


*Related Issue(s)*
*Has Unit Tests (y/n)*
*Documentation Included (y/n)*

Change Description

A description of the changes contained in the PR.

Rationale

A rationale for this change. e.g. fixes bug, or most projects need XYZ feature.

Testing/Review Recommendations

Fill in testing procedures, specific items to focus on for review, or other info to help the team verify these changes are flight-quality.

Future Work

Note any additional work that will be done relating to this issue.

Svc/CmdSequencer/test/int/test_cmd_sequencer.py

+
+def regenerate_file(seqfile1,deployment):
+    # ex: test_seq.seq
+    oldfile1 = open (seqfile1 +".seq", "r")


Svc/CmdSequencer/test/int/test_cmd_sequencer.py

+def regenerate_file(seqfile1,deployment):
+    # ex: test_seq.seq
+    oldfile1 = open (seqfile1 +".seq", "r")
+    newfile1 = open (seqfile1 +"_new.seq", "w")


kevin-f-ortega

@chuynh4duarte, looks good to me. I added some comments for you to address. Thank you

kevin-f-ortega · 2025-06-06T20:18:52Z

Svc/PrmDb/test/int/test_cmd_PrmDb.py

+
+    # 1st remove file PrmDB.dat (manually)
+    # setup directory to remove later
+    fprime_test_api.send_and_assert_command(fprime_test_api.getCmdDispName('Svc.FileManager') + '.' + 'CreateDirectory', ["/tmp/PrmDb"], max_delay=5)    


This will need to get prmdb filename from fprime_test_api

kevin-f-ortega · 2025-06-06T20:19:04Z

Svc/PrmDb/test/int/test_cmd_PrmDb.py

+    # send PRM_SAVE_FILE (Wrote 0 records)
+    fprime_test_api.send_and_assert_command(fprime_test_api.getCmdDispName('Svc.PrmDb') + '.' + 'PRM_SAVE_FILE', max_delay=1)
+    # Verify PrmDB.dat is empty    open /tmp/save_file1 (PrmDb.dat file = 0bytes )
+    fprime_test_api.send_and_assert_command(fprime_test_api.getCmdDispName('Svc.FileManager') + '.' + 'ShellCommand', ["ls -lagt", "/tmp/PrmDb/save_file1"], max_delay=5)


kevin-f-ortega · 2025-06-06T20:27:18Z

Svc/Version/test/int/test_cmd_version.py

+
+    Tests command send, dispatch, and receipt using send_and_assert command with a pair of version commands.
+    """
+    fprime_test_api.send_and_assert_command(fprime_test_api.getCmdDispName('Svc.Version') + '.' + 'VERSION',["PROJECT"], max_delay=1)


This looks good. I would like to add a check that the event reports the expected fsw version and that the telemetry channel matches too.

Same for the other commands like FRAMEWORK, LIBRARY, CUSTOM, ALL

kevin-f-ortega · 2025-06-06T20:30:35Z

Svc/PrmDb/test/int/test_cmd_PrmDb.py

+    # make sure file save
+    time.sleep(2)
+    # Verify PrmDb.dat is increase = 13 bytes     open /tmp/save_file2 (PrmDb.dat file = 13bytes )    
+    fprime_test_api.send_and_assert_command(fprime_test_api.getCmdDispName('Svc.FileManager') + '.' + 'ShellCommand', ["ls -lagt", "/tmp/PrmDb/save_file2"], max_delay=5)        


Should not use ShellCommand this would not work for VxWorks. The script should send a FileDownlink request for the file, once the file is downloaded to the GDS machine, then you can use linux commands in python to get the size.

kevin-f-ortega · 2025-06-06T20:38:15Z

Svc/PrmDb/test/int/test_cmd_PrmDb.py

+
+
+    ## setup default-value
+    fprime_test_api.send_and_assert_command(fprime_test_api.getCmdDispName('Ref.RecvBuff') + '.' + 'PARAMETER1_PRM_SET', [5], max_delay=5)


The component InT tests should not use Ref-specific components like Ref.RecvBuff. Unfortunately, there isn't a deployment-agnostic way to fully test PrmDb. I think this whole test should be moved to the Ref/test/int script.

This test script would only test a nominal PRM_SAVE_FILE, which will unfortunately write 0 records.

kevin-f-ortega · 2025-06-06T20:46:57Z

Svc/FileDownlink/test/int/test_cmd_fileDownlink.py

+    deployment = fprime_test_api.get_deployment()
+
+    ## source = /tmp/file/shell_ls2.log   ,   Dest = /tmp/chuynh/fprime-downlink/DL.log
+    fprime_test_api.send_and_assert_command(deployment + "." + "fileDownlink.SendFile", ["/tmp/file/shell_ls2.log", "DL.log"], max_delay=5)


Update to use the fprime_test_api

kevin-f-ortega · 2025-06-06T20:50:43Z

Svc/CmdSequencer/test/int/test_cmd_sequencer.py

+     CS_JOINT_WAIT  (Need to have more 1 run sequence.  Ref don't have more one sequence)
+    """
+
+    fprime_test_api.send_and_assert_command(fprime_test_api.getCmdDispName('Svc.CmdSequencer') + '.' + 'CS_VALIDATE',["/tmp/ref_test_seq.bin"], max_delay=1)    


This test looks good. But should not use hardcoded files. Topic to discuss with LeStarch

kevin-f-ortega · 2025-06-06T20:54:59Z

Svc/CmdSequencer/test/int/test_cmd_sequencer.py

+#    sequence = Path(__file__).parent / "test_seq_new.seq"
+#    sequence2 = Path(__file__).parent / "test_seq_wait_new.seq"
+
+    sequence = Path(__file__).parent / regenerate_file("test_seq",deployment)


Why do you need to regenerate the sequence file? I think we can just use the original seq file.

kevin-f-ortega · 2025-06-06T20:55:33Z

Svc/CmdSequencer/test/int/test_cmd_sequencer.py

+        == 0
+    ), "Failed to run fprime-seqgen"
+
+    fprime_test_api.send_and_assert_command(


Should we add a test for ref_test_seq_wait.bin ?

kevin-f-ortega · 2025-06-06T20:55:51Z

Svc/CmdSequencer/test/int/test_cmd_sequencer.py

+
+## regenerate .seq file
+
+def regenerate_file(seqfile1,deployment):


Do we still need this function?

kevin-f-ortega · 2025-06-06T21:07:49Z

@chuynh4duarte, could you also add the Ref config json file to the Ref/test/int directory?

kevin-f-ortega · 2025-06-12T00:46:27Z

Svc/CmdSequencer/test/int/test_cmd_sequencer.py

+    newfile1.close()
+    return seqfile1 +"_new.seq"
+
+def test_seqgen(fprime_test_api):


Need to:

Write out a sequence file. e.g.,

Instead of reading the original sequence file, just create the new seq file using this string. This avoids needing to parse the original sequence file """ 00:00:00 {}.CMD_NO_OP 00:00:01 {}.CMD_NO_OP_STRING HELLO """.format(cmdDisplay)

add deployment function

0d0ec31

github-advanced-security bot found potential problems May 14, 2025

View reviewed changes

chuynh4duarte requested a review from kevin-f-ortega May 14, 2025 23:15

Cindy T Huynh added 3 commits June 4, 2025 15:21

update file to use config json file

0a55a2e

remove unuse function

b8850f8

fix typos

a166794

github-advanced-security bot found potential problems Jun 5, 2025

View reviewed changes

Cindy T Huynh and others added 2 commits June 5, 2025 15:24

fixed spelling

b21ebb7

Merge branch 'devel' into InitScript

2a8a1dd

kevin-f-ortega reviewed Jun 6, 2025

View reviewed changes

kevin-f-ortega reviewed Jun 12, 2025

View reviewed changes



		## setup default-value
		fprime_test_api.send_and_assert_command(fprime_test_api.getCmdDispName('Ref.RecvBuff') + '.' + 'PARAMETER1_PRM_SET', [5], max_delay=5)


		## regenerate .seq file

		def regenerate_file(seqfile1,deployment):

add deployment function #3618

Are you sure you want to change the base?

add deployment function #3618

Conversation

chuynh4duarte commented May 14, 2025

Change Description

Rationale

Testing/Review Recommendations

Future Work

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check warning

Check warning

kevin-f-ortega left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kevin-f-ortega commented Jun 6, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!