Add support for CCSDS TC/TM and SpacePacket protocols #3684
+3,771
−669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g with GDS wohooo
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
thomas-bc
commented
Jun 11, 2025
LeStarch
previously approved these changes
Jun 11, 2025
LeStarch
approved these changes
Jun 11, 2025
celskeggs
reviewed
Jun 11, 2025
| packetSequenceControl |= sequenceCount & SpacePacketSubfields::SeqCountMask; // 14 bit sequence count | ||
|
|
||
| FW_ASSERT(data.getSize() <= std::numeric_limits<U16>::max(), static_cast<FwAssertArgType>(data.getSize())); | ||
| U16 packetDataLength = static_cast<U16>(data.getSize() - 1); // Standard specifies length is number of bytes minus 1 |
There was a problem hiding this comment.
Won't this do the wrong thing if data.getSize() == 0?
There was a problem hiding this comment.
@celskeggs the standard doesn't allow for 0 size packets (https://ccsds.org/Pubs/133x0b2e2.pdf paragraph 4.1.2.1)
We are definitely missing an assert on that - good catch, thanks!
|
|
||
| It receives payload data (such as a Space Packet or a VCA_SDU) on input and produces a TC frame on its output port as a result. Please refer to the CCSDS [TC specification (CCSDS 232.0-B-4)](https://ccsds.org/Pubs/232x0b4e1c1.pdf) for details on the frame format and protocol. | ||
|
|
||
| The `Svc::CCSDS::TcDeframer` is designed to work in the common F Prime telemetry stack, receiving data from an upstream [`Svc::ComQueue`](../../../ComQueue/docs/sdd.md) and passing frames to a [Communications Adapter](../../../Interfaces/docs/sdd.md), such as a Radio manager component or [`Svc::ComStub`](../../../ComStub/docs/sdd.md), for transmission on the wire. It is commonly coupled with the [`Svc::CCSDS::SpacePacketFramer`](../../SpacePacketFramer/docs/sdd.md) to wrap CCSDS Space Packets into TM frames. |
There was a problem hiding this comment.
This seems to describe the TmFramer, not the TcDeframer.
There was a problem hiding this comment.
Correct, thanks. I'll make a follow-up PR
thomas-bc
added a commit
that referenced
this pull request
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Fix #3443 #3491 #3492
Add Framers and Deframers (and helpers) to support encapsulating F´ data in CCSDS Space Packets + TC and TM frames.
Each protocol is supported as described by the component SDD.
Rationale
A long standing request by the community.
#1397 #2507 #3026
Future Work
TBD