Skip to content

Neo4jError and ClientError deprecations and small adjustments #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 6.x
Choose a base branch
from
Open

Neo4jError and ClientError deprecations and small adjustments #1179

wants to merge 2 commits into from

Conversation

robsdedude
Copy link
Member

Slightly change Neo4jError and ClientError:

  • Properties message and code are always a str (instead of str | None).
  • Remove possibility to override/set message and code properties.
  • Remove undocumented, internal methods Neo4jError.hydrate, Neo4jError.invalidates_all_connections,
    and Neo4jError.is_fatal_during_discovery.
  • Remove deprecated method Neo4jError.is_retriable.
    Use Neo4jError.is_retryable instead.
  • Change string representation of Neo4jError to include GQL error information.

MaxAake
MaxAake reviewed May 16, 2025
View reviewed changes
Copy link
Contributor

@MaxAake MaxAake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬

@MaxAake @robsdedude
Clean up left-over comment
857e34a 
Signed-off-by: Rouven Bauer <[email protected]>
@robsdedude robsdedude requested a review from MaxAake May 16, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxAake MaxAake Awaiting requested review from MaxAake

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robsdedude @MaxAake