This repository was archived by the owner on Nov 21, 2024. It is now read-only.
Add dockerfile to run locally #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bayandin
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Nice idea, thanks @raoufchebri!
I have a couple of comments/questions, there are rather optional. So you can just merge as is if it blocks you.
Comment on lines
+21
to
+24
| rm -r /tmp/pg_embedding && \ | ||
| apt-get remove -y build-essential postgresql-server-dev-$PG_MAJOR && \ | ||
| apt-get autoremove -y && \ | ||
| rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
Instead of cleaning up things afterwards, I would probably split this into a multi-stage build:
- build pg_embedding
- copy the extension from the previous stage to a fresh
postgres:$PG_MAJORcontainer
Comment on lines
+7
to
+12
| # Locale settings | ||
| RUN apt-get clean && apt-get update && \ | ||
| apt-get install -y locales && \ | ||
| localedef -i en_US -c -f UTF-8 -A /usr/share/locale/locale.alias en_US.UTF-8 | ||
|
|
||
| ENV LANG en_US.utf8 |
There was a problem hiding this comment.
I'm curious, Is this required for the extension, or is it just to make the image more usable?
There was a problem hiding this comment.
I'm not sure this step is required, but I got multiple errors with locale, and this fixed it.
|
@bayandin Will this PR be merged? |
|
@samueldurantes, we have sunsetted |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.