Skip to content

tests: tighten readability rules in test_location_conf_churn #12059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

tests: tighten readability rules in test_location_conf_churn #12059

merged 1 commit into from
May 30, 2025

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented May 29, 2025

Problem

Checking the most recent state of pageservers was insufficient to evaluate whether another pageserver may read in a particular generation, since the latest state might mask some earlier AttachedSingle state.

Related: #11348

Summary of changes

  • Maintain a history of all attachments
  • Write out explicit rules for when a pageserver may read

@jcsp jcsp added t/bug Issue Type: Bug a/test Area: related to testing labels May 29, 2025
@jcsp jcsp requested review from erikgrinaker and alexanderlaw May 29, 2025 11:14
@jcsp jcsp force-pushed the jcsp/issue-11348 branch from 04a90b2 to d090461 Compare May 29, 2025 11:37
@jcsp jcsp mentioned this pull request May 29, 2025
Closed
@jcsp jcsp force-pushed the jcsp/issue-11348 branch from d090461 to 62c765c Compare May 29, 2025 11:38
@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

8514 tests run: 7937 passed, 0 failed, 577 skipped (full report)

Code coverage* (full report)

  • functions: 32.3% (9059 of 28033 functions)
  • lines: 48.6% (79830 of 164330 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
62c765c at 2025-05-29T13:09:42.153Z :recycle:

erikgrinaker
erikgrinaker approved these changes May 30, 2025
View reviewed changes
Copy link
Contributor

@erikgrinaker erikgrinaker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, but I'm not intimately familiar with the details here. We'll find out soon enough if it's sufficient.

@erikgrinaker erikgrinaker mentioned this pull request May 30, 2025
Closed
@jcsp jcsp marked this pull request as ready for review May 30, 2025 10:52
@jcsp jcsp enabled auto-merge May 30, 2025 11:01
@jcsp jcsp added this pull request to the merge queue May 30, 2025
Merged via the queue into main with commit e78d1e2 May 30, 2025
178 of 180 checks passed
@jcsp jcsp deleted the jcsp/issue-11348 branch May 30, 2025 11:20
@alexanderlaw alexanderlaw mentioned this pull request May 30, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request May 30, 2025
@alexanderlaw
Allow known pageserver errors in test_location_conf_churn (#12082)
8d26978 
## Problem
While a pageserver in the unreadable state could not be accessed by
postgres thanks to #12059, it
may still receive WAL records and bump into the "layer file download
failed: No file found" error when trying to ingest them.

Closes: #11348

## Summary of changes

Allow errors from wal_connection_manager, which are considered expected.
See #11348.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikgrinaker erikgrinaker erikgrinaker approved these changes

@alexanderlaw alexanderlaw Awaiting requested review from alexanderlaw

Assignees
No one assigned
Labels
a/test Area: related to testing t/bug Issue Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcsp @erikgrinaker