Skip to content

feat(pageserver): enable gc-compaction by default everywhere #12105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jun 2, 2025

Enable it across tests and set it as default. Marks the first milestone of #9114. We already enabled it in all AWS regions and planning to enable it in all Azure regions next week.

will merge after we roll out in all regions.

@skyzh skyzh changed the title feat(pageserver): enable gc-compaction by default feat(pageserver): enable gc-compaction by default in tests Jun 2, 2025
Copy link

github-actions bot commented Jun 2, 2025

8525 tests run: 7942 passed, 0 failed, 583 skipped (full report)


Flaky tests (2)

Postgres 17

Code coverage* (full report)

  • functions: 32.3% (9043 of 27958 functions)
  • lines: 48.7% (79962 of 164268 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
be46676 at 2025-06-03T04:45:21.762Z :recycle:

@skyzh skyzh requested review from erikgrinaker and problame June 3, 2025 04:10
@skyzh skyzh marked this pull request as ready for review June 3, 2025 04:10
@skyzh skyzh requested a review from a team as a code owner June 3, 2025 04:10
@erikgrinaker
Copy link
Contributor

erikgrinaker commented Jun 3, 2025

nit: consider updating the PR title to say that this enables GC compaction by default (not just in tests but everywhere that it's not specified).

@skyzh skyzh changed the title feat(pageserver): enable gc-compaction by default in tests feat(pageserver): enable gc-compaction by default everywhere Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants