Skip to content

Fixes #19415: Increased Circuit/WirelessLink distance upper limit #19495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 19, 2025
Merged

Fixes #19415: Increased Circuit/WirelessLink distance upper limit #19495

merged 8 commits into from
May 19, 2025
+57 −4

Conversation

jnovinger
Copy link
Member

@jnovinger jnovinger commented May 14, 2025 •
edited
Loading

Fixes: #19415

  • Increases the longest possible distance for Circuits and WirelessLink to accommodate distances up to 100,000 miles (normalize to an upper limit of 160,934,000 meters)
  • Adds form validation to provide useful feedback to user when exceeding distance upper limit
  • Fixes a bug discovered during development where field errors for items in an InlineFields object were not displayed correctly

@jnovinger
Fixes #19415: Increased Circuit/WirelessLink absolute distance upper …
7e1d558 
…limit

Also adds form validation that provides a useful message to the user
rather than a 500 error with potentially little information.
@jnovinger jnovinger changed the title Fixes #19415: Increased Circuit/WirelessLink absolute distance upper … Fixes #19415: Increased Circuit/WirelessLink distance upper limit May 14, 2025
@jnovinger jnovinger requested review from a team and jeremystretch and removed request for a team May 14, 2025 15:48
@jnovinger
Copy link
Member Author

jnovinger commented May 14, 2025 •
edited
Loading

For testing purposes, the new upper limit is 10^14m, which is enough to handle the farthest man-made object from Earth with which we still have a data connection.

@jnovinger jnovinger requested a review from jeremystretch May 16, 2025 16:52
jeremystretch
jeremystretch requested changes May 16, 2025
View reviewed changes
@jnovinger jnovinger requested a review from jeremystretch May 16, 2025 20:15
@jeremystretch jeremystretch merged commit a2a8779 into main May 19, 2025
10 checks passed
@jeremystretch jeremystretch deleted the 19415-circuit-wirelesslink-distance-extension branch May 19, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremystretch jeremystretch jeremystretch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jnovinger @jeremystretch