Skip to content

fix: no frameworks special case for pre-dev-cleanup #6449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

mrstork
Copy link
Contributor

@mrstork mrstork commented Jun 10, 2025

Summary

Remove special handling for remix and hydrogen in pre-dev-cleanup step
(see discussion in #6446 (review))


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@mrstork mrstork changed the title fix: no framework special case for ntl dev fix: no frameworks special case for pre-dev-cleanup Jun 10, 2025
@mrstork mrstork marked this pull request as ready for review June 10, 2025 17:00
@mrstork mrstork requested a review from a team as a code owner June 10, 2025 17:00
@mrstork mrstork merged commit b0ba6d9 into main Jun 10, 2025
60 of 61 checks passed
@mrstork mrstork deleted the no-framework-special-case branch June 10, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants