-
Notifications
You must be signed in to change notification settings - Fork 71
fix: replace js-yaml with yaml package #6469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request adds or modifies JavaScript ( |
f243c4e
to
d518ad9
Compare
|
0f08935
to
1f10139
Compare
This pull request adds or modifies JavaScript ( |
This pull request adds or modifies JavaScript ( |
907be6d
to
3de19bf
Compare
This pull request adds or modifies JavaScript ( |
@@ -1,6 +1,7 @@ | |||
import figures from 'figures' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: is there a policy by which you're deciding which files to convert to ts and which ones not to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The couple I changed were self contained, but when I started working with the other files there were subsequent changes that needed to be made. I simply drew a line in the sand, but ideally we can switch to all TS one day
This pull request adds or modifies JavaScript ( |
Summary
js-yaml
was last published 4 years agoyaml
was last published a month agoFor us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)