Skip to content

fix: replace js-yaml with yaml package #6469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 18, 2025
Merged

fix: replace js-yaml with yaml package #6469

merged 5 commits into from
Jun 18, 2025

Conversation

mrstork
Copy link
Contributor

@mrstork mrstork commented Jun 13, 2025

Summary

  • js-yaml was last published 4 years ago
  • yaml was last published a month ago
  • Bonus: moves 2 packages to dev

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files. Consider converting them to TypeScript.
Thank you for converting JavaScript files to TypeScript 🎉"

@mrstork mrstork force-pushed the swap-yaml-package branch from 0f08935 to 1f10139 Compare June 13, 2025 21:02
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@mrstork mrstork force-pushed the swap-yaml-package branch from 907be6d to 3de19bf Compare June 13, 2025 22:17
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@mrstork mrstork marked this pull request as ready for review June 14, 2025 12:31
@mrstork mrstork requested a review from a team as a code owner June 14, 2025 12:31
@@ -1,6 +1,7 @@
import figures from 'figures'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: is there a policy by which you're deciding which files to convert to ts and which ones not to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The couple I changed were self contained, but when I started working with the other files there were subsequent changes that needed to be made. I simply drew a line in the sand, but ideally we can switch to all TS one day

Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@mrstork mrstork enabled auto-merge (squash) June 18, 2025 17:28
@mrstork mrstork merged commit 1628170 into main Jun 18, 2025
32 of 33 checks passed
@mrstork mrstork deleted the swap-yaml-package branch June 18, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants