fix: handle changed TanStack Start commands #6495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhalp
commented
Jun 26, 2025
| test('detects a TanStack Start React site', async ({ fs }) => { | ||
| test('detects a TanStack Start React site (v1.121.0+)', async ({ fs }) => { | ||
| const cwd = mockFileSystem({ | ||
| 'package.json': JSON.stringify({ |
There was a problem hiding this comment.
serhalp
commented
Jun 26, 2025
|
|
||
| export class TanStackStart extends BaseFramework implements Framework { | ||
| readonly id = 'tanstack-start' | ||
| name = 'TanStack Start' | ||
| npmDependencies = ['@tanstack/start', '@tanstack/react-start', '@tanstack/solid-start'] | ||
| npmDependencies = [ | ||
| // This was the package name until it became `@tanstack/react-start` in v1.111.0 |
There was a problem hiding this comment.
this is just adding a comment for an unrelated previous change, for clarity
eduardoboucas
approved these changes
Jun 26, 2025
…work-detection-config-docs-due-to
serhalp
deleted the
serhalp/frb-1918-update-tanstack-start-framework-detection-config-docs-due-to
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TanStack Start removed the vinxi layer in v1.121.0, so the dev and build commands have changed. The port and publish are are the same. The
app.config.tsfile also no longer exists, but that doesn't affect framework detection here.