Skip to content

Quoted-string Basic realm ctx according to rfc7235 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2016

Conversation

ArfyFR
Copy link
Contributor

@ArfyFR ArfyFR commented Nov 3, 2016

Hi,

I faced some problems with 401 message and an Android client.

It yelded because in the WWW-Authenticate header the
Basic ream=
wasn't surrouned by ""

In the https://tools.ietf.org/html/rfc7235 it is written that

  • Authentication parameters are name=value pairs
  • and "auth-param = token BWS "=" BWS ( token / quoted-string )"
  • and "For historical reasons, a sender MUST only generate the quoted-string
    syntax. Recipients might have to support both token and
    quoted-string syntax for maximum interoperability with existing
    clients that have been accepting both notations for a long time.
    "

After my modification, the Android worked again (and iOs and PC clients faicing the 401 still worked ;) )

BR,
Arfy

Hi,

I faced some problems with 401 message and an Android client.

It yelded because in the WWW-Authenticate header the
Basic ream=<ctx>
wasn't surrouned by ""

In the https://tools.ietf.org/html/rfc7235 it is written that 
 - Authentication parameters are name=value pairs
 - and "auth-param     = token BWS "=" BWS ( token / quoted-string )"
 - and "For historical reasons, a sender MUST only generate the quoted-string
   syntax.  Recipients might have to support both token and
   quoted-string syntax for maximum interoperability with existing
   clients that have been accepting both notations for a long time."

After my modification, the Android worked again (and iOs and PC clients faicing the 401 still worked ;) )

BR,
Arfy
@vl-homutov vl-homutov merged commit b56c9ef into nginxinc:master Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants