Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've been faced with a request at work where a domain had to be login-protected, and have used nginx-ldap-auth to be able to use our LDAP server.
Another request asked me to limit some of this domain's subdirectories to members of different departments.
This patch adds support for group limiting in nginx-ldap-auth. It uses a group fetch and checks the user's presence in the memberUid field of the LDAP group. I made this choice because some LDAP servers (including mine) badly support the memberOf overlay.
I hope it helps and you'll consider upstreaming that patch!
Colin