FIX: The commandline is set --model <undefined>
#12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgxd
reviewed
May 13, 2025
There was a problem hiding this comment.
not a huge fan of assigning a conditional default / arbitrary path in the inputspec - WDYT about:
- removing the logic from inputspec
- adding a check if model is not defined to
SynthStrip._parse_inputsthat will automatically set (and complain if not found) the model
Comment on lines
37
to
45
| _fs_home = os.getenv('FREESURFER_HOME', None) | ||
| _default_model_path = Path(_fs_home) / 'models' / 'synthstrip.1.pt' if _fs_home else Undefined | ||
|
|
||
| use_defaultmodel = False | ||
| if _fs_home and not _default_model_path.exists(): | ||
| _default_model_path = Undefined | ||
| else: | ||
| use_defaultmodel = True | ||
| _default_model_path = str(_default_model_path) |
There was a problem hiding this comment.
imo, this logic should be contained within the SynthStrip interface.
There was a problem hiding this comment.
Happy to improve, but this resolves a current bug.
There was a problem hiding this comment.
Okay, the fix wasn't great. In testing it again, I noticed why we took this route. The idea was to avoid editing CommandLine's run method.
There was a problem hiding this comment.
i opened #13 as an alternative - wdyt?
oesteban
force-pushed
the
fix/nipype-wrapper-model
branch
from
c7e6590 to
d821517
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.