feat(awstf): add custom domains for terraform APIs #785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
requires a rebase @HomelessDinosaur |
HomelessDinosaur
force-pushed
the
feat/aws-domains
branch
from
8d9ece0 to
a8c86aa
Compare
davemooreuws
requested changes
Apr 29, 2025
There was a problem hiding this comment.
This does not seem to support root domains, not sure if pulumi version does either. Sub domains work great.
Example:
apis:
# The nitric name of the API to configure
main:
# Array of domains to apply to the API
# The domain or parent domain must have a hosted zone already in Route53
domains:
- testmydomain.comturns into testmydomain.testmydomain.com whereas it should just work.
HomelessDinosaur
force-pushed
the
feat/aws-domains
branch
from
a111ec1 to
1030a8e
Compare
davemooreuws
approved these changes
May 1, 2025
davemooreuws
changed the title
davemooreuws
changed the title
jyecusch
changed the title
HomelessDinosaur
force-pushed
the
feat/aws-domains
branch
from
1030a8e to
c0954f9
Compare
tjholm
approved these changes
May 2, 2025
|
🎉 This PR is included in version 1.26.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.