fix(azure): prevent conflicting topic subscription names #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #788 +/- ##
=======================================
Coverage 48.83% 48.83%
=======================================
Files 28 28
Lines 3551 3551
=======================================
Hits 1734 1734
Misses 1698 1698
Partials 119 119
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
davemooreuws
approved these changes
Apr 15, 2025
HomelessDinosaur
approved these changes
Apr 15, 2025
jyecusch
force-pushed
the
fix/azure-sub-name-conflicts
branch
from
03f64fb to
7d84229
Compare
jyecusch
force-pushed
the
fix/azure-sub-name-conflicts
branch
from
c8e2c09 to
a0e3e80
Compare
davemooreuws
requested changes
Apr 17, 2025
davemooreuws
approved these changes
Apr 27, 2025
davemooreuws
approved these changes
Apr 28, 2025
|
🎉 This PR is included in version 1.25.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When topic names are long they result in subscriptions names that must be truncated (to max 24 chars) to meet Azure's name restrictions. The truncation could result in two services subscribing to the same topic ending up with the same name for their subscriptions, causing a conflict for the Event Subscription resources.