You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove windows-2019 as it has been removed from GitLab-hosted runners. Example failed run shows:
Windows Server 2019 has been retired. The Windows Server 2019 image has been removed as of 2025-06-30. For more details, see actions/runner-images#12045
question: do we need windows-2025? I think we added windows-2019 because there was some MSVC compilation issues in 2019 that we wanted to solve and test against. Could we just use windows-latest (which resolves to windows-2022, see docs).
question: do we need windows-2025? I think we added windows-2019 because there were some MSVC compilation issues in 2019 that we wanted to solve and test against. Could we just use windows-latest (which resolves to windows-2022, see docs).
The blame doesn't provide much context about when windows-2019 was added, only stating "Revert window CI to running on 2019".
It makes sense to use windows-latest like you mentioned, reading the issue related to runner-images, it seems to be the standard approach to maintain only the latest two stable versions.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-project-automation
bot
moved this from Need Triage
to Done
in Node-API Team Project
Remove
windows-2019as it has been removed from GitLab-hosted runners. Example failed run shows:Add the most recent Windows runner,
windows-2025.