src,lib: support path in v8.writeHeapSnapshot output

[juanarbol]

---

I'm a bit rusty with my C++. Any feedback will be more than valuable.

[codecov]

Codecov Report

Attention: Patch coverage is 69.23077% with 12 lines in your changes missing coverage. Please review.

Project coverage is 90.08%. Comparing base (cc856b3) to head (3ef78c4).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
src/heap_utils.cc	61.29%	6 Missing and 6 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58959      +/-   ##
==========================================
- Coverage   90.09%   90.08%   -0.01%     
==========================================
  Files         640      640              
  Lines      188471   188498      +27     
  Branches    36973    36970       -3     
==========================================
+ Hits       169802   169814      +12     
- Misses      11382    11399      +17     
+ Partials     7287     7285       -2     

Files with missing lines	Coverage Δ
lib/v8.js	99.38% <100.00%> (+<0.01%)	⬆️
src/node_internals.h	81.03% <ø> (ø)
src/heap_utils.cc	78.38% <61.29%> (-1.75%)	⬇️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[addaleax]

Suggested change

	final_filename = std::string(*path) + "/" +
	final_filename = path.ToString() + "/" +

[addaleax]

Suggested change

	std::string(*path) + "/" + std::string(*filename));
	path.ToString() + "/" + filename.ToString();

[addaleax]

Suggested change

	final_filename = std::string(*path) + "/" + std::string(*filename);
	final_filename = path.ToString() + "/" + filename.ToString();

But I'd encourage you to move this line up before the THROW_IF_INSUFFICIENT_PERMISSIONS one and then just use the same variable in that

[addaleax]

Suggested change

	final_filename = *filename;
	final_filename = filename.ToString();

[Renegade334]

getValidatedPath can return a Uint8Array, so typeguarding probably needs to happen before casting?

[jasnell]

You'll want to use BufferValue here... or, skip this and have the BufferValue uses below just accept args[2]. Casting as a string here is incorrect.

[jasnell]

The test should be expanded to cover at least cases such as:

1. Passing the path as a Buffer and as a URL
2. Passing an unwritable path
3. Passing invalid types for path (to test the type checking)

[jasnell]

The BufferValue uses need to be cleaned up