Skip to content

doc: remove broken link to permission model source code #58972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

juanarbol
Copy link
Member

The permission model grew enough to be splited into multiple files, the link in the md file is broken. And as it is not part of a single file, the best way to fix this is just remove the link, many APIs in Node.js does not have the source code linked, this is not bad for our docs.


The link is pointing to https://github.com/nodejs/node/blob/v24.3.0/src/permission.cc, which is a "404". Everything is under src/permission/*.{cc,h} not a single file.

The permission model grew enough to be splited into multiple files, the
link in the md file is broken. And as it is not part of a single file,
the best way to fix this is just remove the link, many APIs in Node.js
does not have the source code linked, this is not bad for our docs.

Signed-off-by: Juan José Arboleda <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 6, 2025
Copy link

@Hardanish-Singh Hardanish-Singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@juanarbol juanarbol added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue Add this label to land a pull request using GitHub Actions. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants