fix(tw): use v3 button styling #7937
Merged
+9
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR restores the Tailwind v3 button cursor: pointer behavior in v4 and updates the comment block with upgrade guide references.
- Added
cursor: pointerrule forbuttonand[role="button"]in the base layer. - Included links to the Tailwind upgrade guide for both cursor and border-color changes.
Comments suppressed due to low confidence (1)
packages/ui-components/styles/index.css:17
- [nitpick] The existing comment block is focused on border-color defaults; consider expanding or splitting it to explicitly document the cursor compatibility change for buttons to improve clarity.
See https://tailwindcss.com/docs/upgrade-guide#buttons-use-the-default-cursor
MattIPv4
approved these changes
Jul 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7937 +/- ##
==========================================
+ Coverage 75.35% 75.40% +0.04%
==========================================
Files 96 96
Lines 8354 8354
Branches 220 219 -1
==========================================
+ Hits 6295 6299 +4
+ Misses 2057 2053 -4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
MattIPv4
reviewed
Jul 3, 2025
MattIPv4
reviewed
Jul 3, 2025
MattIPv4
reviewed
Jul 3, 2025
aymen94
approved these changes
Jul 3, 2025
github-actions
bot
removed
the
github_actions:pull-request
ovflowd
reviewed
Jul 4, 2025
|
Thanks for the comments, and sorry for the delay, I'll resolve them ASAP. |
Signed-off-by: Aviv Keller <[email protected]>
avivkeller
force-pushed
the
fix/tailwind-default-button
branch
from
8e61ad1 to
3a11bb4
Compare
araujogui
approved these changes
Jul 7, 2025
github-actions
bot
removed
the
github_actions:pull-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Tailwind v4, buttons use the
defaultcursor, rather than thepointercursor, see https://tailwindcss.com/docs/upgrade-guide#buttons-use-the-default-cursor.