Skip to content

fix(downloads/choco): use current name/version #7944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2025

Conversation

JosefBud
Copy link
Contributor

@JosefBud JosefBud commented Jul 3, 2025

Description

Fixes #7943 where choco install nodejs-lts --version="22" does not work due to the --version="22" argument being used with the nodejs-lts package. This PR changes those snippets to use the nodejs package instead, and specifies the full version instead of only specifying the major.

Validation

Ran the dev build and verified.

image

image

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
    image
  • I have run pnpm test to check if all tests are passing.
    image
  • I have run pnpm build to check if the website builds without errors.
    image
  • (N/A) I've covered new added functionality with unit tests if necessary.

@JosefBud JosefBud requested a review from a team as a code owner July 3, 2025 21:21
Copy link

vercel bot commented Jul 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 3, 2025 9:38pm

Copy link
Contributor

github-actions bot commented Jul 3, 2025

Note

Your Pull Request seems to be updating Translations of the Node.js Website.

Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project.
We recommend giving a read on our Translation Guidelines.

Thank you!

@avivkeller avivkeller changed the title fix: change choco download snippets to use nodejs package and specify full version fix(downloads): use current name/version Jul 3, 2025
@avivkeller avivkeller changed the title fix(downloads): use current name/version fix(downloads/choco): use current name/version Jul 3, 2025
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall that it was intentional back then to use the package nodejs-lts, but it seems to be outdated and missing many vewrsions now? So weird.

It is hard for us to monitor what 3rd party providers are doing 🤦

Thanks for the change!

@JosefBud
Copy link
Contributor Author

JosefBud commented Jul 4, 2025

@ovflowd No problem! Happy to help out.

Is there anything else I need to do to kick off the pending CI checks?

@bjohansebas bjohansebas added the github_actions:pull-request Trigger Pull Request Checks label Jul 4, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 4, 2025
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.41%. Comparing base (663cb52) to head (c319659).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7944      +/-   ##
==========================================
+ Coverage   75.35%   75.41%   +0.05%     
==========================================
  Files          96       96              
  Lines        8354     8354              
  Branches      220      219       -1     
==========================================
+ Hits         6295     6300       +5     
+ Misses       2057     2052       -5     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller
Copy link
Member

@ovflowd No problem! Happy to help out.

Is there anything else I need to do to kick off the pending CI checks?

Nope, one of us started them :-)

@ovflowd ovflowd added this pull request to the merge queue Jul 5, 2025
Merged via the queue into nodejs:main with commit cd48cc3 Jul 5, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download snippet for Chocolatey includes argument that doesn't work
5 participants