-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix(downloads/choco): use current name/version #7944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Note Your Pull Request seems to be updating Translations of the Node.js Website. Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project. Thank you! |
…y full version in version arg
c57b3c1
to
c319659
Compare
choco
download snippets to use nodejs
package and specify full versionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recall that it was intentional back then to use the package nodejs-lts, but it seems to be outdated and missing many vewrsions now? So weird.
It is hard for us to monitor what 3rd party providers are doing 🤦
Thanks for the change!
@ovflowd No problem! Happy to help out. Is there anything else I need to do to kick off the pending CI checks? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7944 +/- ##
==========================================
+ Coverage 75.35% 75.41% +0.05%
==========================================
Files 96 96
Lines 8354 8354
Branches 220 219 -1
==========================================
+ Hits 6295 6300 +5
+ Misses 2057 2052 -5
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Nope, one of us started them :-) |
Description
Fixes #7943 where
choco install nodejs-lts --version="22"
does not work due to the--version="22"
argument being used with thenodejs-lts
package. This PR changes those snippets to use thenodejs
package instead, and specifies the full version instead of only specifying the major.Validation
Ran the dev build and verified.
Related Issues
Check List
pnpm format
to ensure the code follows the style guide.pnpm test
to check if all tests are passing.pnpm build
to check if the website builds without errors.I've covered new added functionality with unit tests if necessary.