fix: improve clipboard success animation in code blocks (#7946) #7950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
avivkeller
reviewed
Jul 4, 2025
There was a problem hiding this comment.
Does setting the swipeDirection not do all of this for you?
There was a problem hiding this comment.
swapDirection only indicates the direction of the animation. It only takes effect once the appropriate animation classes are added in the CSS module.
There was a problem hiding this comment.
I am not sure about animation is required or not. But this implementation follows radix docs.
LGTM!
avivkeller
requested changes
Jul 5, 2025
Comment on lines
15
to
+35
|
|
||
| .root[data-state='open'] { | ||
| animation: slide-in 300ms cubic-bezier(0.16, 1, 0.3, 1); | ||
| } | ||
|
|
||
| .root[data-state='closed'] { | ||
| animation: slide-out 200ms ease-in forwards; | ||
| } | ||
|
|
||
| .root[data-swipe='move'] { | ||
| transform: translateX(var(--radix-toast-swipe-move-x)); | ||
| } | ||
|
|
||
| .root[data-swipe='cancel'] { | ||
| transform: translateX(0); | ||
| transition: transform 200ms ease-out; | ||
| } | ||
|
|
||
| .root[data-swipe='end'] { | ||
| animation: swipe-out 150ms ease-out forwards; | ||
| } |
There was a problem hiding this comment.
A) I'm not sure how I feel about the added complexity of a swipe
B) use tailwinds @apply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves the clipboard success animation for code blocks.
The previous animation was abrupt and barely visible, which felt out of place compared to the otherwise modern UI. This PR introduces a smoother transition, to improve visibility and user experience.
Validation
Tested locally by clicking the copy button on multiple code blocks.
The new animation is clearly visible, smoother, and feels more consistent with the design language of the site.
Related Issues
Fixes #7946
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.Screen.Recording.2025-07-04.at.3.09.44.PM.mov