-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
feat(BaseLinkTabs): add hover effect #7953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a hover effect on the blog page menu links in both light and dark modes to improve visual feedback.
- Adds a non-active hover style for BaseLinkTabs to change border and text colors.
- Ensures dark-mode variants are handled consistently.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7953 +/- ##
==========================================
- Coverage 75.37% 75.35% -0.03%
==========================================
Files 96 96
Lines 8354 8354
Branches 220 220
==========================================
- Hits 6297 6295 -2
- Misses 2055 2057 +2
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
@Mohit5Upadhyay Can you rebase? |
Description
This PR adds a hover effect to the blog page menu links to improve the user experience and visual feedback when navigating the blog section. This PR resolves issue #7952 by introducing a hover effect for various categories both for dark-mode and light-mode.
Validation
blog-tabs-hover.mp4
Related Issues
Fixes #7952
Check List
pnpm format
to ensure the code follows the style guide.pnpm test
to check if all tests are passing.pnpm build
to check if the website builds without errors.