Skip to content

chore(logo): update non-stacked public assets #7956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

avivkeller
Copy link
Member

Ref #7880.

This PR updates the public assets' non-stacked logo variants to use the newer icon.

CC @AugustinMauroy @MattIPv4 I intentionally didn't update @node-core/ui-components's icons, since they have the pride variants, if you two don't mind looking into that.

@Copilot Copilot AI review requested due to automatic review settings July 6, 2025 14:36
@avivkeller avivkeller requested a review from a team as a code owner July 6, 2025 14:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Copy link

vercel bot commented Jul 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 6, 2025 2:36pm

Copy link

codecov bot commented Jul 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.36%. Comparing base (ab0ba1d) to head (6f3ec0d).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7956   +/-   ##
=======================================
  Coverage   75.36%   75.36%           
=======================================
  Files          96       96           
  Lines        8354     8354           
  Branches      220      220           
=======================================
  Hits         6296     6296           
  Misses       2056     2056           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller
Copy link
Member Author

avivkeller commented Jul 6, 2025

If you'd like me to also update the stacked variants in this PR, draft this PR and let me know. (This is separate right now, since updating the stacked logos requires a lot more math.

@MattIPv4
Copy link
Member

MattIPv4 commented Jul 6, 2025

Is there a reason ui-components doesn't just use the same SVGs, rather than a custom component that requires complex maintenance to combine two different SVGs into one?

@MattIPv4
Copy link
Member

MattIPv4 commented Jul 6, 2025

And what's the reasoning for not updating the stacked versions?

@avivkeller
Copy link
Member Author

And what's the reasoning for not updating the stacked versions?

I'm more than happy to, it's just exponentially more math, so I figured it'd be better to get these out, since they are done

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT but what about the component one ?

@avivkeller
Copy link
Member Author

LGMT but what about the component one ?

See the PR description

@AugustinMauroy
Copy link
Member

Is there a reason ui-components doesn't just use the same SVGs, rather than a custom component that requires complex maintenance to combine two different SVGs into one?

/cc @ovflowd you was requiring during 2024 pride month

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants