-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
chore(logo): update non-stacked public assets #7956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7956 +/- ##
=======================================
Coverage 75.36% 75.36%
=======================================
Files 96 96
Lines 8354 8354
Branches 220 220
=======================================
Hits 6296 6296
Misses 2056 2056
Partials 2 2 ☔ View full report in Codecov by Sentry. |
If you'd like me to also update the stacked variants in this PR, draft this PR and let me know. (This is separate right now, since updating the stacked logos requires a lot more math. |
Is there a reason ui-components doesn't just use the same SVGs, rather than a custom component that requires complex maintenance to combine two different SVGs into one? |
And what's the reasoning for not updating the stacked versions? |
I'm more than happy to, it's just exponentially more math, so I figured it'd be better to get these out, since they are done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT but what about the component one ?
See the PR description |
/cc @ovflowd you was requiring during 2024 pride month |
Ref #7880.
This PR updates the public assets' non-stacked logo variants to use the newer icon.
CC @AugustinMauroy @MattIPv4 I intentionally didn't update
@node-core/ui-components
's icons, since they have the pride variants, if you two don't mind looking into that.