Upgrade Jest to latest (v23.6) #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is probably going to be a breaking change since Jest v22 drops support for Node 4 |
|
Can it be merged asap? :) @laardee |
|
lgtm 👍 @artoliukkonen can you review this? |
|
Any idea if this will be merged and released? |
|
Thanks for the contribution, and sorry we are lagging behind with merging & releasing these changes. Will definitely try to improve on this. Releasing new version to NPM soon. |
|
Thanks a ton! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve the open issues with upgrading the Jest dependency, since it's extremely out-of-date. I also updated the serverless framework to the current latest.
I tried to keep the changes to the minimum required to get the tests passing. Anything else were just artifacts of VS Code running the
eslintconfig (mostly just in__tests__/test-utils.js)Please let me know if there's anything else I can update for this PR to be merged in. Thanks!