-
Notifications
You must be signed in to change notification settings - Fork 81
StripWhitespace still works in blacklisted file #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I mean, the It's a normal use case to remove whitespace in a file where you don't want to display it, be it manually or with autocommands, so I don't think we should disable the command on blacklisted files. |
That's a good point, but you should change your README accordingly. As it is, you have written, "To disable this plugin for specific file types...", but the plugin is not disabled by the blacklist, just the highlighting of whitespaces. Your README needs to state that. When I've some time, I'll look again, see if I can add the full disabling, as I'd prefer, in a fork. A minor point of readability: just below the contested statement, you've "If you do not want any of these filetypes unignored" which I suggest you change to "If you prefer to also keep these default filetypes ignored" - to avoid the double negative. |
Disabling the plugin ≠ disabling the functionality. Fixes #114
Disabling the plugin ≠ disabling the functionality. Fixes ntpeters#114
Resolved in #121 |
I can open a
markdown
file in which the whitespaces aren't highlighted, and:StripWhitespace
, and they're all gone, without any visible sign that they've been removed. A little risky...The fix would be to also disable the
StripWhitespace
function for blacklisted files.The text was updated successfully, but these errors were encountered: