Pull all recent updates #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignores aliases set in the shell by default, which closes ntpeters#109
Frees up :match for other uses, as seen in ntpeters#98, also less :exe. A single matchadd() id should be used because matchadd() goes over from one buffer to the next, so creating a new id causes matchadd/matchdelete calls to not work as expected. It seems that using the same match id across buffers does not seem to interfere with other open buffers, neither in tabs nor splits.
Disabling the plugin ≠ disabling the functionality. Fixes ntpeters#114
Our trim() substitute needs to handle new lines as well, otherwise it returns a string with just a new line, which then causes problems.
Disabling the plugin ≠ disabling the functionality. Fixes ntpeters#114
|
This fixes #120. However, would it be better to do function detection: https://stackoverflow.com/a/13710385/2839477 instead of version checking? Since for nvim the version check is failing and then it's using the fallback, but nvim actually does have the |
This allows the check to be correct on vim variants that do not follow the version scheme, e.g. nvim. As suggested by @therealjumbo on ntpeters#121.
| " Function to implement trim() fro vim < 8.0.1630 | ||
| if v:version > 800 || (v:version == 800 && has('patch-1630')) | ||
| " Function to implement trim() if it does not exist | ||
| if exists('*trim') |
There was a problem hiding this comment.
I tested this, and in nvim, it is correctly using this case now.
|
Thanks for the quick turnaround, I'm using your fork/branch until this gets merged. Hopefully soon-ish :) |
ntpeters
requested changes
Oct 23, 2019
|
Thanks for collecting these into a single PR to make the review easier! ❤️ |
Instead of diff which may be aliased in some way, e.g. diff.cmd See ntpeters#121, ntpeters#111 and ntpeters#109.
This was referenced Oct 23, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes
trim()functionmatchadd()instead of:matchtrim()function: 2f9aa7b useexists()rather than checking version number