Feat: Use type & version on image naming instead of branch #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilagomatis
force-pushed
the
feat_fw_version
branch
from
bc3fb76 to
d816bc9
Compare
ananos
approved these changes
May 15, 2025
Currently, when we build the same repo twice, but with different versions or application types (say, 0.0.0 and 1.1.1), the uploaded firmware and container images for 1.1.1 would override the 0.0.0 application images. Used type and version in naming to fix that. PR: #4 Signed-off-by: Ilias Lagomatis <[email protected]> Reviewed-by: Anastassios Nanos <[email protected]> Approved-by: Anastassios Nanos <[email protected]>
github-actions
bot
force-pushed
the
feat_fw_version
branch
from
d816bc9 to
933f852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when we build the same repo twice, but with different
versions or application types (say, 0.0.0 and 1.1.1), the uploaded
firmware and container images for 1.1.1 would override the 0.0.0
application images. Used type and version in naming to fix that.